Project

General

Profile

Bug #133

ZWave interface: If "Poll Interval" is blank/empty, Domotiga crashes

Added by Alexie about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
05/18/2012
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Hi Ron,

If go into the Setup -> Interfaces -> Z-Wave and i empty the Open Z-Wave "Poll Interval", Domotiga crashes and i will not start anymore at all.

Fix is easy in "FSettingsZWave.class", replace the following:

PUBLIC SUB btnSave_Click()

  DIM rResult AS Result
  ...

with:

 PUBLIC SUB btnSave_Click()

  DIM rResult AS Result

  IF vbPolltime.Value = NULL THEN
    vbPolltime.Value = 0
  END IF

  ...

Ps1. the same applies for "FSettingsThermostat.class", but i don't use this one yet.
Ps2. In "FSettingsTermostat.class" i would replace "PUBLIC SUB vbPolltime_KeyPress()" with "PUBLIC SUB vbPolltime_Change()". This makes it more consistent with the other input fields of Domotiga

Regards,
Alex

History

#1 Updated by rdnzl about 7 years ago

Ok I will fix it, I also want to have things as generic as possible, but thats not always easy, thanks.

#2 Updated by rdnzl about 7 years ago

  • Status changed from New to In Progress

#3 Updated by rdnzl about 7 years ago

  • Status changed from In Progress to Feedback

Fixed this in r884 and r885.

#4 Updated by Alexie about 7 years ago

Hi Ron,

I tested it and it works fine.

Regards,
Alex

#5 Updated by rdnzl about 7 years ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF